Author: lryan
Date: Thu Aug 20 16:07:04 2009
New Revision: 806235

URL: http://svn.apache.org/viewvc?rev=806235&view=rev
Log:
Don't turn inability to detect image type into server error, instead just 
return an empty response.

Modified:
    
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java

Modified: 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java
URL: 
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java?rev=806235&r1=806234&r2=806235&view=diff
==============================================================================
--- 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java
 (original)
+++ 
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java
 Thu Aug 20 16:07:04 2009
@@ -107,7 +107,10 @@
         } catch (IOException ioe) {
           throw new RuntimeException(ioe);
         } catch (ImageReadException ire) {
-          throw new RuntimeException(ire);
+          // Unable to read the image so its not safe
+          logger.log(Level.INFO, "Unable to detect image type for " 
+request.getUri().toString() +
+              " for sanitized content", ire);
+          return true;
         }
       } else {
         return true;


Reply via email to