Author: lindner
Date: Thu Sep 24 04:52:10 2009
New Revision: 818368
URL: http://svn.apache.org/viewvc?rev=818368&view=rev
Log:
pedantic findbugs/checkstyle fixes
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AccountImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/BodyTypeImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ListFieldImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MessageCollectionImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/AuthenticationHandlerProvider.java
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
Thu Sep 24 04:52:10 2009
@@ -69,13 +69,13 @@
bind(new TypeLiteral<List<AuthenticationHandler>>(){}).toProvider(
AuthenticationHandlerProvider.class);
-
+
bind(new
TypeLiteral<Set<Object>>(){}).annotatedWith(Names.named("org.apache.shindig.social.handlers"))
.toInstance(getHandlers());
-
-
bind(Long.class).annotatedWith(Names.named("org.apache.shindig.serviceExpirationDurationMinutes")).toInstance(60l);
+
+
bind(Long.class).annotatedWith(Names.named("org.apache.shindig.serviceExpirationDurationMinutes")).toInstance(60L);
}
-
+
/**
* Hook to provide a Set of request handlers. Subclasses may override
* to add or replace additional handlers.
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AccountImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AccountImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AccountImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AccountImpl.java
Thu Sep 24 04:52:10 2009
@@ -20,9 +20,9 @@
import org.apache.shindig.social.opensocial.model.Account;
public class AccountImpl implements Account {
- String domain;
- String userId;
- String username;
+ private String domain;
+ private String userId;
+ private String username;
public AccountImpl() { }
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/BodyTypeImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/BodyTypeImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/BodyTypeImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/BodyTypeImpl.java
Thu Sep 24 04:52:10 2009
@@ -22,7 +22,7 @@
/**
* see
* <a
href="http://www.opensocial.org/Technical-Resources/opensocial-spec-v081/opensocial-reference#opensocial.BodyType";>
- *
http://www.opensocial.org/Technical-Resources/opensocial-spec-v081/opensocial-reference#opensocial.BodyType</a>
+ *
http://www.opensocial.org/Technical-Resources/opensocial-spec-v081/opensocial-reference#opensocial.BodyType</a>.
*
*/
public class BodyTypeImpl implements BodyType {
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ListFieldImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ListFieldImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ListFieldImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/ListFieldImpl.java
Thu Sep 24 04:52:10 2009
@@ -20,9 +20,9 @@
import org.apache.shindig.social.opensocial.model.ListField;
public class ListFieldImpl implements ListField {
- String type;
- String value;
- Boolean primary;
+ private String type;
+ private String value;
+ private Boolean primary;
public ListFieldImpl() { }
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MediaItemImpl.java
Thu Sep 24 04:52:10 2009
@@ -64,6 +64,6 @@
public void setUrl(String url) {
this.url = url;
}
- public String getThumbnailUrl() { return this.thumbnailUrl;}
- public void setThumbnailUrl(String url) { this.thumbnailUrl = url;}
+ public String getThumbnailUrl() { return this.thumbnailUrl; }
+ public void setThumbnailUrl(String url) { this.thumbnailUrl = url; }
}
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MessageCollectionImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MessageCollectionImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MessageCollectionImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/MessageCollectionImpl.java
Thu Sep 24 04:52:10 2009
@@ -32,8 +32,8 @@
private Date updated;
private List<Url> urls;
- public MessageCollectionImpl() {}
-
+ public MessageCollectionImpl() { }
+
public String getId() {
return id;
}
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java
Thu Sep 24 04:52:10 2009
@@ -163,7 +163,7 @@
public Map<String, ? extends Object> getAppData() {
return this.appData;
}
-
+
public void setAppData(Map<String, ? extends Object> appData) {
this.appData = appData;
}
@@ -461,7 +461,7 @@
public void setPoliticalViews(String politicalViews) {
this.politicalViews = politicalViews;
}
-
+
public String getPreferredUsername() {
return preferredUsername;
}
@@ -621,7 +621,7 @@
public void setIsViewer(boolean isViewer) {
this.isViewer = isViewer;
}
-
+
// Proxied fields
public String getProfileUrl() {
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/AuthenticationHandlerProvider.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/AuthenticationHandlerProvider.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/AuthenticationHandlerProvider.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/AuthenticationHandlerProvider.java
Thu Sep 24 04:52:10 2009
@@ -40,4 +40,4 @@
public List<AuthenticationHandler> get() {
return handlers;
}
-}
\ No newline at end of file
+}
Modified:
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java
URL:
http://svn.apache.org/viewvc/incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java?rev=818368&r1=818367&r2=818368&view=diff
==============================================================================
---
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java
(original)
+++
incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth/OAuthAuthenticationHandler.java
Thu Sep 24 04:52:10 2009
@@ -48,7 +48,7 @@
import javax.servlet.http.HttpServletRequest;
/**
- * Handle both 2-legged consumer and full 3-legged OAuth requests
+ * Handle both 2-legged consumer and full 3-legged OAuth requests.
*/
public class OAuthAuthenticationHandler implements AuthenticationHandler {
