Great - that makes sense Cassie.

I can take a whack at #5 after your next set of changes.

Cheers
Chak



On 1/14/08 3:34 PM, "Cassie" <[EMAIL PROTECTED]> wrote:

> On Sun, Jan 13, 2008 at 8:55 PM, Kevin Brown <[EMAIL PROTECTED]> wrote:
> 
>> On Jan 13, 2008 3:37 PM, Chak Nanga <[EMAIL PROTECTED]> wrote:
>> 
>>> Hi,
>>> 
>>> I've been able to check out/build/run/test the Gadget Server and the
>>> sample container. However, I have the following questions/comments:
>>> 
>>> - What is the purpose of the javascript/gadgets dir since the features
>>> directory has pretty much the same stuff in it (and gets included as
>>> part of the gadget rendering code)
>> 
>> 
>> features/ is where features (which may include javascript files) go.
>> javascript/ is where core javascript (such as the reference in-memory
>> container) go. Currently some of the code in features/ is replicated in
>> javascript/ because we have to fix some dependency issues elsewhere. This
>> will go away shortly.
>> 
>> 
>>> 
>>> - The samplecontainer.html, by default, points to
>>> 
>>> 
>> http://hosting.gmodules.com/ig/gadgets/file/117247905274371511495/caja-clickm
>> e.xml
>>>    - This gadget does not work and genertates several errors
>>>    - The caja-clickme.xml gadget code has "<Require
>>> feature="opensocial-samplecontainer"/>" which is confusing. I thinkf
>>> adding support for <Require feature="opensocial-0.[5|6]"/> instead
>>> will make it closer to the spec
>> 
>> 
>> But this gadget actually does rely on functionality from
>> opensocial-samplecontainer because it's designed to serve as an example. I
>> agree that it probably should be using opensocial-0.6 and the container is
>> what should be running this code, but I believe there are some legitimate
>> reasons for this not being the case currently (probably because IFPC was
>> not
>> implemented until very recently, if I had to guess). Whatever the reason
>> for
>> it, it does look like something that we have the means to fix now, so if
>> someone wants to improve this I don't see any reason why not.
>> 
>> 
>>>    - The caja-clickme.xml gadget code (as expected) has Caja related
>>> code (instead of the "regular" gadget code). This does not seem like
>>> the first gadget a beginner should be seeing.
>>> As a beginner, this is pretty confusing to me since none of the API
>>> docs talk about Caja and the very first gadget that the
>>> samplecontainer.html points to is a Caja gadget which neither the
>>> OpenSocial API/Orkut dev guides talk about.
>>> 
>>> I think adding support for <Require feature="opensocial"> in the
>>> Gadget Server and fixing up the samplecontainer.html to include the
>>> appropriate JS files to support OpenSocial gadgets will make it a bit
>>> more easy for someone to get the environment up and running for
>>> hosting basic OpenSocial gadgets (and then move on to hosting caja
>>> enabled gadgets)
>> 
>> 
>> This makes sense to me as well. The Caja gadget should probably have a
>> separate html file to illustrate how caja gadgets work, and the
>> samplecontainer.html should include more basic gadgets as reference. Feel
>> free to open an issue in jira on this.
> 
> 
> 
> samplecontainer.html supports both regular gadgets and caja gadgets. i
> didn't realize i had made the complicated caja-clickme gadget the default,
> if we just change that to a non-caja gadget and check it in that should
> solve everybody's problems.
> 
> the require feature has to stay equal to "opensocial-samplecontainer"
> because this sample uses mock data. shindig will, very shortly, also add
> support for opensocial-0.6, 7 etc with a container that hits the server for
> data. this isn't done yet, but once that happens that should clear up the
> rest of your confusions, right?
> 
> so, to be exact, the things to do here are:
> 
> 1. check in some sample gadgets for people to play with. at least 1 caja and
> 1 non-caja
> 2. change samplecontainer.html to default to the checked in non-caja simple
> gadget
> 3. implement the server side based container under the correct feature
> heading
> 4. fix the rest of the caja errors (this is a wip, this code is very
> volatile right now. the errors the default gadget generates are because of
> caja isues. i should have those resolved by eod tomorrow)
> 5. update any docs to make things easier to figure out
> 
> I'll have a change for 1, 2, and 4 hopefully tomorrow. 3 will take a little
> more time but is coming soon. If anyone wants to volunteer for 5, please go
> for it.
> 
> Thanks!
> 
> - Cassie
> 
> 
>> 
>> 
>>> 
>>> Thanks
>>> Chak
>>> 
>> 


Reply via email to