[
https://issues.apache.org/jira/browse/SHINDIG-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563885#action_12563885
]
Kevin Brown commented on SHINDIG-27:
------------------------------------
Sorry for the late follow up on this.
I think this works, but I think the extra interface is overkill. I'm a little
hesitant on the implementation because it starts a separate executor which
can't be configured, and this can complicate debugging.
Also, Shindig code should not include authorship information.
I'll try to get this in sometime this weekend, but I'd like your thoughts first.
> Hookup Gadget blacklist implementation to the Gadget Server
> -----------------------------------------------------------
>
> Key: SHINDIG-27
> URL: https://issues.apache.org/jira/browse/SHINDIG-27
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Chak Nanga
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: blacklist_patch.txt
>
>
> Currently there is a BasicGadgetBlacklist class, however, it's not being
> utilized (i.e. being init'd and read in) by the Gadget Server. While we're at
> it, we should also implement a mechanism to be able to dynamically update the
> blacklist file without having to restart the server.
> Proposed solution:
> 1. Read in the black list file name from web.xml (as a context-param)
> 2. Implement a file change listener mechanism that can be used to monitor
> changes to the blacklist file and reload it on changes.
> I can work on the patch if you agree on the proposed solution
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
