Re: svn commit: r617309 - in /incubator/shindig/trunk: java/gadgets/ java/gadgets/src/main/java/org/apache/shindig/gadgets/ java/gadgets/src/main/java/org/apache/shindig/gadgets/http/ javascript/samplecontainer/

[Jamey Wood]

[EMAIL PROTECTED] wrote:
Author: johnh
Date: Thu Jan 31 15:56:48 2008
New Revision: 617309
URL: http://svn.apache.org/viewvc?rev=617309&view=rev
Log:
Views support for Shindig.

This implements SHINDIG-41, conforming to the canonical Gadget XSD. View ID 
semantics are
that view IDs are split on commas, and each view ID found appends to the 
content for that view.
This allows for code sharing between views and provides a relatively clean 
implementation.

A blank or nonexistent view maps to ID "default".

Changes are made to be backwards-compatible, maintaining the old parameter-less
GadgetSpec.getContentData() API. TBD: whether to deprecate this method.
  

I'm now seeing compilation errors:

src/test/java/org/apache/shindig/gadgets/GadgetSpecTestFixture.java:[97,30] 
<anonymous org.apache.shindig.gadgets.GadgetSpecTestFixture$1> is not 
abstract and does not override abstract method 
getContentData(java.lang.String) in org.apache.shindig.gadgets.GadgetSpec

I presume that GadgetSpecTestFixture should be changed to have the new 
"getContentData(String view)" method (along the lines of the attached diff)?

Thanks,
Jamey
Index: src/test/java/org/apache/shindig/gadgets/GadgetSpecTestFixture.java
===================================================================
--- src/test/java/org/apache/shindig/gadgets/GadgetSpecTestFixture.java	(revision 617317)
+++ src/test/java/org/apache/shindig/gadgets/GadgetSpecTestFixture.java	(working copy)
@@ -58,6 +58,13 @@
         public String getContentData() {
           return DATETIME_CONTENT;
         }
+        public String getContentData(String view) {
+          if (view == null || view.equals("") || view.equals(DEFAULT_VIEW)) {
+            return DATETIME_CONTENT;
+          } else {
+            return null;
+          }
+        }
         public URI getContentHref() {
           return null;
         }