On Feb 16, 2008 5:20 AM, Chris Chabot <[EMAIL PROTECTED]> wrote: > Thanks, clears things up quite a bit. > > Once the patch lands i'll mirror it in the port I'm working on, better > to mimic the behavior as closely as possible for now i guess, makes > following 'upstream' a lot easier on a whole. > > Ps one general remark, for when someone has some spare time he'd like > to fill with some code rewriting, there's a good few small terminology > inconsistencies in the code, such as calling something 'Required' in > the spec and gadget spec parser loops, but in the parsed gadget spec, > it has a isOptional, so the boolean is flipped around in the > processFeature function, such things happen in a few locations where > the terminology used internally isn't quite consistent, which might > make it a little less readable to the less seasoned programmers.
Indeed -- The entire "Gadget" heirarchy (GadgetSpec / GadgetView / Gadget / ParsedGadget) is very kludgy and is in need of some significant refactoring, as is GadgetServer. You'll have to bear with us a bit on this one as we've had a lot of code to write and not a lot of time to do it in, so our code reviews haven't been applied as thoroughly as we would normally like. Really, we're not as big of amateurs as some of this code might lead you to believe ;-). > > Pps, as you might have been able to tell, i'm working on a propper PHP > shindig implementation (the current one is nothing more then a proof > of concept with a lot of hard coded assumptions and can't be seen as a > implementation really), i've chosen to mirror the java version as > closely as possible in PHP, which should make it a bit cross > maintainable since the logic structures in both will be identical > (except for the jetty part that is). The gadget spec parser with all > its dependencies is just about done, and i hope to have the other bits > done in the coming weeks. > > What would be the easiest way to submit my work as a proposed new php > code base, shall i make a code.google.com project out of it and mail > the url to it here or what would be preferred? We already have a PHP sub-directory, and some other people were actively working on this. You might want to check the mail archives to see who's doing what, as I've kind of forgotten myself. Also, have you investigated using the Java implementation and simply talking to it from your PHP code base using the RpcServlet? A few other people have had success with this approach and it might get you what you're looking for.
