[
https://issues.apache.org/jira/browse/SHINDIG-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572999#action_12572999
]
Cassie Doll commented on SHINDIG-97:
------------------------------------
This looks great! Just a couple of things before I patch:
- we use 2 spaces for all indents (yours either has tabs or 4 spaces in it)
- all brackets should be surrounded by spaces so "if (...) {"
- could the auto json use "fooBar" instead of "foo_bar"? the former is
compatible with our javascript objects
Do you want to make a new patch or should I?
One last thing is that I think there are some libraries out there which will go
to and from json automatically. I think this is a fantastic start though and we
can swap in some library later.
Thanks!
> [PATCH] method toJson for java social pojo
> ------------------------------------------
>
> Key: SHINDIG-97
> URL: https://issues.apache.org/jira/browse/SHINDIG-97
> Project: Shindig
> Issue Type: New Feature
> Components: Gadgets Server - Java
> Reporter: Vincent Demay
> Assignee: John Hjelmstad
> Attachments: toJson.patch.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
