i, I committed a skins implmentation. I'd appreciate it if the javascript experts could review it. Some notes: * The skins code uses idioms from views.js to interact with gadgets.config. This resulted in converting the object style declarations with a function closure. Is this okay? I didn't see anything in the style guide about this * I declared a new skins entry in syndicator.js that uses a properties declaration with an ExistsValidator - should we add validity checks for each and every field? * I added gadgets.Skins.init(properties), which allows the set of properties to be set. This is needed so the container can dynamically set the skins values on a user-by-user basis. * Do we want to automatically set up the skins styles for the gadget when rendered in an iframe? I'm thinking that we could add code like this: document.bgColor = gadgets.skins.getProperty(gadgets.skins.Property.BG_COLOR); document.body.style.color = gadgets.skins.getProperty(gadgets.skins.Property.FONT_COLOR); ... In the inlined-caja context this will already be true, might as well make it work in a consistent way in the iframes. Thanks
-- Paul Lindner hi5 Architect [EMAIL PROTECTED]
