El sáb, 01-03-2008 a las 16:06 -0800, Luciano Resende escribió: > I'm fine with the proposal. If others are OK I'll provide a patch and > would appreciate if someone could then run the "remove keyword script" > on the repository.
I have already a patch. As I said, I discovered this while testing the use of git and git-svn for offline commit. I have actually two patches: * remove svn:keywords from the script, and add a line for removing them from the repository * revert the two files touched by keyword expansion (two jquery.js versions). I can run the scripts too and commit the results. I just wanted to know if there was a reason to activate svn:keywords or if it was, as I thought, a leftover in the script from other projects that are using it. Regards Santiago > On Sat, Mar 1, 2008 at 12:27 AM, Santiago Gala <[EMAIL PROTECTED]> wrote: > > > > El vie, 29-02-2008 a las 11:26 -0800, Luciano Resende (JIRA) escribió: > > > > > [ > > > https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 > > > ] > > > > > > Luciano Resende commented on SHINDIG-78: > > > ---------------------------------------- > > > > > > What's your suggestion here ? remove the usage of keywords ? or remove > > the property in special cases and/or file types ? > > > > > > > I noticed it in a strange way: I'm experiementing with the use of > > git-svn to track one of out repositories while keeping the whole > > history. When I diff'ed a standard svn working copy with a git-svn > > produced, I was not expecting any difference except for the .svn > > directories in the svn WC and the .git one at the head of the git one. > > But I found those two files. Strangely, the keyword expansion is done by > > the client code, and I guess the svn client code in git-svn is not > > compliant enough. > > > > That led me to search on it. I seem to remember that the best practices > > in the ASF re: keywords in source code was to remove them even before we > > migrated to subversion in 2004. At first I thought that they were coming > > from some external Google repository (actually they were coming from the > > jquery.org one). But the strange thing is that it was our script that > > added the svn:keyword to the typed files. > > > > My idea would be to remove the svn:keyword property from all the files > > in the repository, and from the script that does the tagging. Probably > > also to restore the jquery expansions, that shows us that we are using > > 1.2.1 instead of the last released 1.2.3 But I might be wrong and the > > svn:keywords stuff have a rationale, or practices be different in > > different areas of the ASF. > > > > What do you think? > > > > Regards > > Santiago > > > > > > > > > > Add sample svn:props and svn:ignore sample files + script to set > > values in existent project files > > > > > > ------------------------------------------------------------------------------------------------- > > > > > > > > Key: SHINDIG-78 > > > > URL: https://issues.apache.org/jira/browse/SHINDIG-78 > > > > Project: Shindig > > > > Issue Type: Bug > > > > Reporter: Luciano Resende > > > > Assignee: Brian McCallister > > > > Attachments: lresende.shindig-78.patch > > > > > > > > > > > > > > > > -- > > Santiago Gala > > http://memojo.com/~sgala/blog/ > > > > > > > -- Santiago Gala http://memojo.com/~sgala/blog/
