[
https://issues.apache.org/jira/browse/SHINDIG-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Lindner resolved SHINDIG-91.
---------------------------------
Resolution: Fixed
Hi, I checked in a simpler fix in revision 632965. Chomping all input seems
dangerous.
Can someone with windows test this? I created a number of variations or CR,
CRLF and LF and this patch parsed all of features.txt without fail.
> Error reading entries from features.txt because of line endings
> ---------------------------------------------------------------
>
> Key: SHINDIG-91
> URL: https://issues.apache.org/jira/browse/SHINDIG-91
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Environment: Windows
> Reporter: Paul Feaviour
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: ResourceLoader.patch
>
>
> ResourceLoader is splitting new lines on \n - SVN is probably set to use
> native EOL for txt files which results in the following error on a Windows
> platform:
> SEVERE: Allocate exception for servlet xml-to-html
> java.io.FileNotFoundException: Can not locate resource:
> features/analytics/feature.xml
> at
> org.apache.shindig.util.ResourceLoader.getContent(ResourceLoader.java:49)
> at
> org.apache.shindig.gadgets.JsFeatureLoader.loadResources(JsFeatureLoader.java:140)
> at
> org.apache.shindig.gadgets.JsFeatureLoader.loadFeatures(JsFeatureLoader.java:81)
> at
> org.apache.shindig.gadgets.GadgetFeatureRegistry.registerFeatures(GadgetFeatureRegistry.java:81)
> at
> org.apache.shindig.gadgets.GadgetFeatureRegistry.<init>(GadgetFeatureRegistry.java:65)
> at
> org.apache.shindig.gadgets.http.DefaultCrossServletState.init(DefaultCrossServletState.java:177)
> at
> org.apache.shindig.gadgets.http.CrossServletState.get(CrossServletState.java:62)
> at
> org.apache.shindig.gadgets.http.GadgetRenderingServlet.init(GadgetRenderingServlet.java:71)
> at
> org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1161)
> at
> org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:806)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:129)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:263)
> at
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
> at
> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:584)
> at
> org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
> at java.lang.Thread.run(Thread.java:619
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
