Good work, Chris. It's much appreciated. Everyone should be aware that in order to make this work, we had to make one minor adjustment to syndicator configuration handling (at least for the default config). It looks like my tests weren't thorough, and PHP DOES complain about trailing commas. You can safely leave them in if you like for your own syndicator configurations, but for the time being the default syndicator config won't use them.
We came up with a workaround for comments in there as well. On Wed, Mar 5, 2008 at 12:11 PM, Paul Lindner <[EMAIL PROTECTED]> wrote: > Hi Chris, I've committed the patch for SHINDIG-103. > > We should definitely get you commit access. To get started > please fill out the contributor license agreement found here: > > http://www.apache.org/licenses/ > > Then we can work on sponsoring you then getting you commit access. > > On 3/5/08 9:36 AM, "Chris Chabot" <[EMAIL PROTECTED]> wrote: > > > So far no protests it seems :) > > > > Of course I'm not sitting still on this side and have a few bug fixes, > > reworked some of the proxy code (curl_multi acting up in a funky way), > > a re-factoring of the gadget / view / spec bit ready, plus implemented > > a few more of Kevin's suggestions, so i have a next patch ready > > already, and I'm currently unsure what to do with it, being able to > > diff against the main branch and submit bug's with patches would be > > easier, commit access would be easier still and uncomplicate my life a > > whole lot :) > > > > -- Chris > > > > On Mar 4, 2008, at 2:20 PM, Cassie wrote: > > > >> > >> Without the copied directory, which you have fixed, I propose we > >> patch this. > >> Anybody not in favor of patching? > > > > -- ~Kevin
