[
https://issues.apache.org/jira/browse/SHINDIG-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575750#action_12575750
]
Cassie Doll commented on SHINDIG-102:
-------------------------------------
I patched your code in with the following changes:
- some files were missing the apache header
- the new person and address objects didn't exactly match the spec. no biggie,
i double checked them all
- i condensed the PersonTest into just one class AbstractSocialDataTest.
because the test is exercising functionality in the base class i figured it was
a little more appropriate to name it that. Also, as there was only one test I
didn't see the need quite yet for the three mock classes. I just condensed them
in for now just to simplify a little
- and finally, i just caught all of the exceptions within the toJson method so
that callers didn't have to deal with them. this was just a nicety for the rest
of the code.
overall:
- nice work on the test! that was a great addition
- the code worked seamlessly with what was already in svn. adding the phone
number to the state file worked pretty magically well. that is a great
improvement
thanks for the contribution!
> [Patch] more social data and toJson in action
> ---------------------------------------------
>
> Key: SHINDIG-102
> URL: https://issues.apache.org/jira/browse/SHINDIG-102
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Vincent Demay
> Assignee: Cassie Doll
> Attachments: socialData.patch.txt
>
>
> I added some social data to the org.apache.shindig.social package and a unit
> test to test toJson Method (SHINDIG-79)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
