On Thu, 2008-03-13 at 10:34 -0700, Kevin Brown wrote:

> Agreed, although I worry about it biting us in the future.


I'll add a (config based) blacklist to it then, so that when we do have
features that break on it, we have an easy way to exclude them from the
compressing.


> It seems that you could  generalize this:
> 
> $input = escapeshellarg($feature_js_file);
> $output = escapeshellarg($out_file);
> exec(sprintf($command, $input, $output), null, $status);
> if ($status === 0) {
>   // successfully compressed.
>   $minified = file_get_contents($out_file);
> }
> 
> where $command looks like:
> 
> "java -jar yuicompressor-2.2.5.jar -o %2 -type js %1"


Will do :)

    -- Chris

Reply via email to