OK, attachment was removed:

Index: GadgetSpecFetcher.java
===================================================================
--- GadgetSpecFetcher.java      (revision 637100)
+++ GadgetSpecFetcher.java      (working copy)
@@ -52,7 +52,7 @@
   public GadgetSpec fetch(URI url, boolean forceReload) throws
GadgetException {
     GadgetSpec spec = null;
     if (!forceReload) {
-      cache.get(url);
+      spec = cache.get(url);
     }
     if (spec == null) {
       RemoteContentRequest request = new RemoteContentRequest(url);


I said it was tiny!

-----Original Message-----
From: Dan Lester [mailto:[EMAIL PROTECTED] 
Sent: 14 March 2008 13:55
To: [email protected]
Subject: Small patch for cache bug in latest version of
GadgetSpecFetcher



I just noticed a problem where the latest GadgetSpecFetcher does not
seem to load from cache. That's because it doesn't, due to a slight
oversight:

It was calling cache.get(url) without storing the return value anywhere,
before checking (spec==null). The attatched one-liner patch just
replaces it with spec = cache.get(url).

Probably easier just to edit it manually, but I attached the patch for
completeness.

Thanks,

Dan

Reply via email to