You should add these things to the style guide http://cwiki.apache.org/confluence/display/SHINDIGxSITE/Java+Style
On Tue, Mar 18, 2008 at 5:20 PM, <[EMAIL PROTECTED]> wrote: > Author: lindner > Date: Tue Mar 18 17:20:37 2008 > New Revision: 638658 > > URL: http://svn.apache.org/viewvc?rev=638658&view=rev > Log: > convert one character strings to char constants > > Modified: > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicRemoteContentFetcher.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RemoteContentRequest.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/SignedFetchRequestSigner.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultCrossServletState.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/BlobCrypter.java > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/HashUtil.java > > > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetTestFixture.java > > > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/ProxyHandlerTest.java > > > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicRemoteContentFetcher.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicRemoteContentFetcher.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicRemoteContentFetcher.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicRemoteContentFetcher.java > Tue Mar 18 17:20:37 2008 > @@ -70,7 +70,7 @@ > if (!first) { > first = true; > } else { > - headerList.append(","); > + headerList.append(','); > } > headerList.append(val); > } > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RemoteContentRequest.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RemoteContentRequest.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RemoteContentRequest.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RemoteContentRequest.java > Tue Mar 18 17:20:37 2008 > @@ -248,7 +248,7 @@ > @Override > public String toString() { > StringBuilder buf = new StringBuilder(); > - buf.append(method).append(" ").append(uri.getPath()).append(" > HTTP/1.1\r\n") > + buf.append(method).append(' ').append(uri.getPath()).append(" > HTTP/1.1\r\n") > .append("Host: ").append(uri.getHost()) > .append(uri.getPort() == 80 ? "" : ":" + uri.getPort()) > .append("\r\n"); > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/SignedFetchRequestSigner.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/SignedFetchRequestSigner.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/SignedFetchRequestSigner.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/SignedFetchRequestSigner.java > Tue Mar 18 17:20:37 2008 > @@ -184,7 +184,7 @@ > } > String finalQuery = OAuth.formEncode(newQuery); > return new URL(resource.getProtocol(), resource.getHost(), > - resource.getPort(), resource.getPath() + "?" + finalQuery); > + resource.getPort(), resource.getPath() + '?' + finalQuery); > } catch (Exception e) { > throw new GadgetException(GadgetException.Code.INTERNAL_SERVER_ERROR > , > e); > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultCrossServletState.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultCrossServletState.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultCrossServletState.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultCrossServletState.java > Tue Mar 18 17:20:37 2008 > @@ -101,7 +101,7 @@ > buf.append(iframePath) > .append("url=") > .append(URLEncoder.encode(url, "UTF-8")) > - .append("&"); > + .append('&'); > } else { > // type = url > buf.append(url); > @@ -120,7 +120,7 @@ > for (Map.Entry<String, String> entry : prefs.getPrefs().entrySet()) > { > buf.append("&up_") > .append(entry.getKey()) > - .append("=") > + .append('=') > .append(URLEncoder.encode(entry.getValue(), "UTF-8")); > } > } catch (UnsupportedEncodingException e) { > @@ -143,7 +143,7 @@ > boolean firstDone = false; > for (String feature : features) { > if (firstDone) { > - buf.append(":"); > + buf.append(':'); > } else { > firstDone = true; > } > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java > Tue Mar 18 17:20:37 2008 > @@ -322,9 +322,9 @@ > * @param query > */ > private void appendLibsToQuery(Set<String> libs, StringBuilder query) { > - query.append("&") > + query.append('&') > .append(LIBS_PARAM_NAME) > - .append("=") > + .append('=') > .append(state.getJsUrl(libs, context)); > } > > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java > Tue Mar 18 17:20:37 2008 > @@ -130,12 +130,12 @@ > public String toString() { > StringBuilder buf = new StringBuilder(); > buf.append("<Module>\n") > - .append(modulePrefs).append("\n"); > + .append(modulePrefs).append('\n'); > for (UserPref pref : userPrefs) { > - buf.append(pref).append("\n"); > + buf.append(pref).append('\n'); > } > for (Map.Entry<String, View> view : views.entrySet()) { > - buf.append(view.getValue()).append("\n"); > + buf.append(view.getValue()).append('\n'); > } > buf.append("</Module>"); > return buf.toString(); > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java > Tue Mar 18 17:20:37 2008 > @@ -366,40 +366,40 @@ > public String toString() { > StringBuilder buf = new StringBuilder(); > buf.append("<ModulePrefs") > - .append(" title=\"").append(title).append("\"") > - .append(" author=\"").append(author).append("\"") > - .append(" author_email=\"").append(authorEmail).append("\"") > - .append(" > author_affiliation=\"").append(authorAffiliation).append("\"") > - .append(" author_location=\"").append(authorLocation).append("\"") > - .append(" author_photo=\"").append(authorPhoto).append("\"") > - .append(" author_aboutme=\"").append(authorAboutme).append("\"") > - .append(" author_quote=\"").append(authorQuote).append("\"") > - .append(" author_link=\"").append(authorLink).append("\"") > - .append(" description=\"").append(description).append("\"") > - .append(" directory_title=\"").append(directoryTitle).append("\"") > - .append(" screenshot=\"").append(screenshot).append("\"") > - .append(" thumbnail=\"").append(thumbnail).append("\"") > - .append(" height=\"").append(height).append("\"") > - .append(" width=\"").append(width).append("\"") > - .append(" category=\"").append(categories.get(0)).append("\"") > - .append(" category2=\"").append(categories.get(1)).append("\"") > - .append(" show_stats=\"").append(showStats).append("\"") > - .append(" > show_in_directory=\"").append(showInDirectory).append("\"") > - .append(" singleton=\"").append(singleton).append("\"") > - .append(" scaling=\"").append(scaling).append("\"") > - .append(" scrolling=\"").append(scrolling).append("\"") > + .append(" title=\"").append(title).append('\"') > + .append(" author=\"").append(author).append('\"') > + .append(" author_email=\"").append(authorEmail).append('\"') > + .append(" > author_affiliation=\"").append(authorAffiliation).append('\"') > + .append(" author_location=\"").append(authorLocation).append('\"') > + .append(" author_photo=\"").append(authorPhoto).append('\"') > + .append(" author_aboutme=\"").append(authorAboutme).append('\"') > + .append(" author_quote=\"").append(authorQuote).append('\"') > + .append(" author_link=\"").append(authorLink).append('\"') > + .append(" description=\"").append(description).append('\"') > + .append(" directory_title=\"").append(directoryTitle).append('\"') > + .append(" screenshot=\"").append(screenshot).append('\"') > + .append(" thumbnail=\"").append(thumbnail).append('\"') > + .append(" height=\"").append(height).append('\"') > + .append(" width=\"").append(width).append('\"') > + .append(" category=\"").append(categories.get(0)).append('\"') > + .append(" category2=\"").append(categories.get(1)).append('\"') > + .append(" show_stats=\"").append(showStats).append('\"') > + .append(" > show_in_directory=\"").append(showInDirectory).append('\"') > + .append(" singleton=\"").append(singleton).append('\"') > + .append(" scaling=\"").append(scaling).append('\"') > + .append(" scrolling=\"").append(scrolling).append('\"') > .append(">\n"); > for (URI preload : preloads) { > buf.append("<Preload href=\"").append(preload).append("\"/>\n"); > } > for (Feature feature : features.values()) { > - buf.append(feature).append("\n"); > + buf.append(feature).append('\n'); > } > for (Icon icon : icons) { > - buf.append(icon).append("\n"); > + buf.append(icon).append('\n'); > } > for (LocaleSpec locale : locales.values()) { > - buf.append(locale).append("\n"); > + buf.append(locale).append('\n'); > } > buf.append("</ModulePrefs>"); > return buf.toString(); > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/UserPref.java > Tue Mar 18 17:20:37 2008 > @@ -123,11 +123,11 @@ > .append(required) > .append("\" datatype=\"") > .append(dataType.toString().toLowerCase()) > - .append("\""); > + .append('\"'); > if (enumValues.size() == 0) { > buf.append("/>"); > } else { > - buf.append("\n"); > + buf.append('\n'); > for (Map.Entry<String, String> entry : enumValues.entrySet()) { > buf.append("<EnumValue value=\"") > .append(entry.getKey()) > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/BlobCrypter.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/BlobCrypter.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/BlobCrypter.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/BlobCrypter.java > Tue Mar 18 17:20:37 2008 > @@ -126,12 +126,12 @@ > for (Map.Entry<String, String> stringStringEntry : in.entrySet()) { > Map.Entry<String, String> val = stringStringEntry; > sb.append(URLEncoder.encode(val.getKey(), UTF8)); > - sb.append("="); > + sb.append('='); > sb.append(URLEncoder.encode(val.getValue(), UTF8)); > - sb.append("&"); > + sb.append('&'); > } > sb.append(TIMESTAMP_KEY); > - sb.append("="); > + sb.append('='); > sb.append(timeSource.currentTimeMillis()/1000); > return sb.toString().getBytes(UTF8); > } > > Modified: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/HashUtil.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/HashUtil.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/HashUtil.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/util/HashUtil.java > Tue Mar 18 17:20:37 2008 > @@ -46,7 +46,7 @@ > byte[] hash = md.digest(data); > // Convert to hex. possibly change to base64 in the future for smaller > // signatures. > - StringBuilder hexString = new StringBuilder(); > + StringBuilder hexString = new StringBuilder(hash.length * 2 + 2); > for (byte b : hash) { > hexString.append(Integer.toHexString(0xFF & b)); > } > > Modified: > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetTestFixture.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetTestFixture.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetTestFixture.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetTestFixture.java > Tue Mar 18 17:20:37 2008 > @@ -75,7 +75,7 @@ > if (!first) { > first = true; > } else { > - bs.append(":"); > + bs.append(':'); > } > bs.append(lib); > } > > Modified: > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/ProxyHandlerTest.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/ProxyHandlerTest.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/ProxyHandlerTest.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/ProxyHandlerTest.java > Tue Mar 18 17:20:37 2008 > @@ -159,7 +159,7 @@ > public void appendTo(StringBuffer sb) { > sb.append("SignedFetchArgumentMatcher("); > sb.append(expectedUrl); > - sb.append(")"); > + sb.append(')'); > } > > @Override > > Modified: > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java?rev=638658&r1=638657&r2=638658&view=diff > > ============================================================================== > --- > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java > (original) > +++ > incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java > Tue Mar 18 17:20:37 2008 > @@ -35,7 +35,7 @@ > > String xml = "<Content" + > " type=\"html\"" + > - " view=\"" + viewName + "\"" + > + " view=\"" + viewName + '\"' + > " quirks=\"false\"><![CDATA[" + > content + > "]]></Content>"; > > > -- ~Kevin
