On Thu, Mar 27, 2008 at 3:56 PM, Brian Eaton <[EMAIL PROTECTED]> wrote:
> On Thu, Mar 27, 2008 at 3:43 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > > I think it looks fine -- some minor issues like using StringBuffers > instead > > of StringBuilders in non-threaded code, but we can always fix that > later. > > Did I add any of those? Unclear -- could have been remnants of something else. I was looking at the raw patch file. Should I fix them when I'm modifying code in their general vicinity? I generally favor fixing small issues like incorrect line wrapping and minor optimizations as you go, but if other people prefer that this always happen in dedicated patches I'm fine with that. -- ~Kevin
