One comment on the original cl: Why do all of the social classes need throws GadgetException in their signatures? I can't see anywhere this is thrown in the current social code, and furthermore, the design is set up so that the service implementations always handle their own exceptions and return a proper error code. Allowing them to both return an error code and return an exception is just confusing.
Are you going to change this in the second submit? Thanks! - Cassie On Sat, Mar 29, 2008 at 2:38 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > Ok, this actually didn't work out as I planned. I'm going to roll this > patch > back and then include it with the Guice patch to make life less painful. > > Sorry everyone. >
