On Wed, Apr 2, 2008 at 9:50 AM, Brian Eaton <[EMAIL PROTECTED]> wrote:
> Looks good to me. A few comments > > - I needed to change one line in ProxyHandler.java so that an > authorization type of "" was treated as equivalent to "none". > > - How would someone override SigningFetcherFactory so that it can > return a subclass of SigningFetcher? Is it just a matter of changing > web.xml to point to a different GuiceModule? Yes, anyone using a custom version of any of these classes needs to provide their own Guice module. Previously they would have had to provide their own CrossServletState. > > > Cheers, > Brian > > On Tue, Apr 1, 2008 at 11:18 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > > Indeed, it looks like something weird with renaming files. I've put up a > new > > patch that deletes and creates new instead (which loses version > history, > > unfortunately). > > > > > > > > On Tue, Apr 1, 2008 at 10:20 AM, Brian Eaton <[EMAIL PROTECTED]> wrote: > > > > > Hrm. That patch doesn't apply for me. svn diff bug? > > > > > > On Mon, Mar 31, 2008 at 3:26 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > > > > Hey everyone, > > > > > > > > I've got the Guice patch working with Brian Eaton's signing > change. > > > Attached > > > > here: https://issues.apache.org/jira/browse/SHINDIG-152 > > > > > > > > I want to get this committed tonight. > > > > > > > > -- > > > > ~Kevin > > > > > > > > > > > > > > > -- > > ~Kevin > > > -- ~Kevin
