[ 
https://issues.apache.org/jira/browse/SHINDIG-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587395#action_12587395
 ] 

Alejandro Rivero commented on SHINDIG-188:
------------------------------------------

I have been informed that it is not a bug; the actual way is the way dictated 
in the API specs; so it is really a question of the API and the corresponding 
issue has been then raised in the workgroup.

Still, the Json container could be patched to do both: answer to 
.getData().each() and to .getData().activities.each(). 



> .getData() doesn't return an Collection<activities>
> ---------------------------------------------------
>
>                 Key: SHINDIG-188
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-188
>             Project: Shindig
>          Issue Type: Bug
>          Components: OpenSocial - Javascript
>            Reporter: Alejandro Rivero
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In file features/opensocial-0.7/jsoncontainer.js
> the function JsonContainer.prototype.newFetchActivitiesRequest
> programs the request to return
>         return {'activities' : new opensocial.Collection(activities)};
> and it should return
>         return new opensocial.Collection(activities) 
> according the API, or at least if the API is interpreted as in the example of 
> FetchPeople.
> Indeed, compare with JsonContainer.prototype.newFetchPeopleRequest = 
> function(idSpec, opt_params) {
> in the same file. This function is programmed to return
>         return new opensocial.Collection(people,...
> and then the javascript code works as told in the Developer guide.
> The only question about/against this correction is if there is already some 
> production system supporting the undocumented result getData().activities.  
> If it were so, the patch becomes more complex because it should support this 
> legacy code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to