[
https://issues.apache.org/jira/browse/SHINDIG-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588525#action_12588525
]
Cassie Doll commented on SHINDIG-192:
-------------------------------------
Thanks for the patch! The code looks good but there are three things you will
need to fix:
1. It looks like you generated the patch from your root directory. If you look
at the first line you will see "Index: C:/projects/shindig/java". This won't
work in my client simply because I use a different directory setup. If you
first cd into "C:/projects/shindig/"and then make the patch it should use
relative paths which will allow anyone to use it.
2. The spacing around the switch statement got messed up. If you look at the
diff you will see that the "case" lines should be kept indented by 2 spaces.
3. I think the very first change you made where "new Comparator" is brought up
a line violates the 80 col rule.
If you attach a new one then I will be able to commit it.
> Guard against null friends
> --------------------------
>
> Key: SHINDIG-192
> URL: https://issues.apache.org/jira/browse/SHINDIG-192
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Ross Gardler
> Priority: Minor
> Attachments: guardAgainstNullFriends.diff
>
>
> The BasicPeopleService needs to guard against null friends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
