On Mon, Apr 14, 2008 at 4:45 PM, David Primmer <[EMAIL PROTECTED]> wrote:
> I logged into dan's review board and reviewed a simple patch. Lets use > it! I think we should encourage people to make a jira issue, add a > link to the review board issue and then submit the patch to review > board, then when it's approved in review board we can: I agree -- but we still don't have "real" infrastructure for this, do we? Dan? How did you generate the patch that you uploaded, by the way? I couldn't seem to make it work using the standard svn diff. > just point to the approved review board issue in jira (since review > board will cc shindig-dev on discussions, maybe that's enough) > or > put the final patch in jira > > and wait for a member to check in. This is probably only necessary for those without commit access. For someone who does have commit access, doing everything through review board (with the link in JIRA) will be sufficient. It doesn't make sense to me to continually add new patch snapshots and > discussion during a review to the jira. It's just too clunky for the > jira interface. I'm trying to make a balance between having all the > info in one place and avoiding copying data or creating too many > emails to the list. Agreed. JIRA is an issue tracker, not a code review tool. -- ~Kevin
