[
https://issues.apache.org/jira/browse/SHINDIG-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589783#action_12589783
]
Louis Ryan commented on SHINDIG-197:
------------------------------------
Agreed, deferring to later patch however.
Fixed (and fixed my IDE too! )
Not sure what you mean here. We still need to annotate if we want the
receiving side of the injection to control whats bound, if not then we
should eliminate the annotations altogether and control binding in the
module. In general I'd prefer to keep using annotations and have simpler
interfaces. ProxiedContentFetcher doesnt seem to be used anywhere and could
just be removed.
I think this belongs in spec so we avoid forward-dependency nastiness from
spec into implementation code. Move to top-level in spec as Auth.
- Class comments shouldn't have authorship info
Done
Done
Most conusmers of cache are passing RemoteContentRequest & RemoteContent
Yup, thats what the code is doing. Only errors if theres some junk value in
the attribute.
Nope, not needed yet anyway
> Add support for authenticated/signed preloads. Refactor caching code to allow
> for caching of same.
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-197
> URL: https://issues.apache.org/jira/browse/SHINDIG-197
> Project: Shindig
> Issue Type: New Feature
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Louis Ryan
> Assignee: Louis Ryan
> Attachments:
> Introduce_support_for__authenticated_preloads_Refactored_caching_to_allow_for_caching_of_signed_requests_(lots_of_cleanup).patch
>
>
> This is a pretty extensive change, the first part adds support for an 'authz'
> attribute to the Preload element as part of the spec. THIS IS A SPEC
> ENHANCEMENT!
> The second part adds a reworking of the Caching code to separate the caching
> interface from the fetcher interface, encapsulate cacheability checking and
> generally make to code cleaner and more manageable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
