ah.. just kidding about the commit fyi: svn commit access id down for maintenance so both this patch and the build fixing patches will have to wait i suppose.
- cassie On Tue, Apr 29, 2008 at 1:53 PM, Cassie Doll (JIRA) <[EMAIL PROTECTED]> wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593007#action_12593007] > > Cassie Doll commented on SHINDIG-210: > ------------------------------------- > > So I am going to check this patch in almost as is. I have only made > modifications to the service interfaces. The methods you added Vasu didn't > really match up with the style nor meaning of the other added methods so I > tried to reconcile things. The activity service is all fine, the methods > have gadget tokens and return response items and the adapter is good. > > The people service on the other hand needs to be reconciled. The rest apis > for /uid/@all/pid don't make sense with our code. The services and sample > container don't have any concept of "contacts". Because the interfaces > should remain more stable I took this stuff out until we can figure out the > proper way to do things cleanly. For example, we should use the gadget token > properly. That is how we do all of our permission checking and data > restriction. With the gadget token it almost seems like > > people/john.doe/@all/jane.doe == people/jane.doe/@self > > john.doe doesn't really come into play at all unless he happens to be the > viewer (or owner) in the current context. > So... we'll want to resolve that conceptual problem through email before we > change the service apis. > > Also - that RestGuiceModule has a lot of bindings which should probably > just move into the SocialApiGuiceModule. You had a todo here so you may know > that already. > > Thanks, and I look forward to more patches! > > - Cassie > > > Implement RESTful spec in Shindig > > --------------------------------- > > > > Key: SHINDIG-210 > > URL: https://issues.apache.org/jira/browse/SHINDIG-210 > > Project: Shindig > > Issue Type: New Feature > > Components: RESTful API (Java) > > Reporter: Bob Evans > > Attachments: restful.patch > > > > > > This is a placeholder for a patch to add RESTful services to access the > opensocial data services. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
