1, yes sorry, cut and paste error, fixed, will updated.
2. The problem is MECLIPSE-444 which will be fixed in 2.5.2, not
certain what to do here ? Users can edit the eclipse project to fix
the errors..... but it would be nice to make it work.
Alternatively,
svn mv javascript jstemp
svn commit
svn mkdir javascript
svn mv jstemp javascript/src
and then add a pom with a zip target so the javascript can be packaged.
features probably want to be a jar
..... but I dont know if that is acceptable for other languages ?
(please advise)
3. I should probably update my local copy and recreate the branch and
fix. Will do.
4. Fixed, yes
5. Fixed, yes
6. Really, checked and couldn't see anything ?
7. Will update and regen the patch
8.
There was a pom there already so I thought that was the right place.
For those that open up, read the read me, build and want to just
build the java code, they don't have to cd anywhere....... but that
might not be right as more servers come in. It could all be moved
into java, along with the build instructions. (please advise)
moving will mean we have to get MECLIPSE-444 fixed.
Ian
On 30 Apr 2008, at 14:32, Cassie Doll (JIRA) wrote:
[ https://issues.apache.org/jira/browse/SHINDIG-207?
page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel&focusedCommentId=12593327#action_12593327 ]
Cassie Doll commented on SHINDIG-207:
-------------------------------------
So before we commit this patch it looks like:
1. The root/README file should not be changed to remove the php and
javascript references. (I think this might be just a copy and paste
error)
2. the eclipse instructions don't work for everyone
3. the web.social.xml and web.full.xml files are missing the new
rest servlet
4. there is a commented out section in server/pom.xml for the
execution war thing, can we just delete it?
5. why does server/README have different build instructions than
BUILD-JAVA
6. java/pom.xml - there is some more commented out stuff in here
which can probably just be deleted
7. java/social-api/pom.xml - unfortunately the patch is out of date
with head for this file
8. just curious - why do we have a pom.xml file in our root
directory? this seems weird as the root directory also has the php
project in it, and all the java specific stuff should go in the
java dir. right?
simplify dependencies, document how to get eclipse working
----------------------------------------------------------
Key: SHINDIG-207
URL: https://issues.apache.org/jira/browse/
SHINDIG-207
Project: Shindig
Issue Type: Bug
Reporter: Brian Eaton
Attachments: build-cleanup.patch, reorganize-poms5.patch
Got a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
