Thanks Vincent! Fixing now... - Cassie
On Sat, May 3, 2008 at 3:13 PM, Vincent Siveton <[EMAIL PROTECTED]> wrote: > Hi Cassie, > > 2008/4/18, [EMAIL PROTECTED] <[EMAIL PROTECTED]>: > > Author: doll > > Date: Fri Apr 18 05:29:54 2008 > > New Revision: 649495 > > > > URL: http://svn.apache.org/viewvc?rev=649495&view=rev > > Log: > > Added a new CommonGuiceModule. This contains all the guice bindings that > will be the same for the social and gadgets servers. This enables the > servers to run by themseleves and to run together (because in guice you > can't bind something more than once) > > > > Note: This class belongs in the java/common package. However, I can not > put it there right now because it depends on gadgets packages. This can not > be fixed until all of the social gadgets dependencies are refactored. It > will be fixed in the future though. > > > > > > Added: > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/ > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/CommonGuiceModule.java > > Modified: > > > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java > > incubator/shindig/trunk/java/gadgets/src/main/webapp/WEB-INF/web.xml > > > incubator/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/SocialApiGuiceModule.java > > > incubator/shindig/trunk/java/social-api/src/main/webapp/WEB-INF/web.xml > > > > Added: > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/CommonGuiceModule.java > > URL: > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/CommonGuiceModule.java?rev=649495&view=auto > > > > ============================================================================== > > --- > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/CommonGuiceModule.java > (added) > > +++ > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/common/CommonGuiceModule.java > Fri Apr 18 05:29:54 2008 > > @@ -0,0 +1,23 @@ > > +package org.apache.shindig.common; > > + > > +import com.google.inject.AbstractModule; > > +import org.apache.shindig.gadgets.BasicGadgetTokenDecoder; > > +import org.apache.shindig.gadgets.BasicRemoteContentFetcher; > > +import org.apache.shindig.gadgets.GadgetTokenDecoder; > > +import org.apache.shindig.gadgets.RemoteContentFetcher; > > + > > +/** > > + * Provides social api component injection > > + */ > > +public class CommonGuiceModule extends AbstractModule { > > + > > + /** [EMAIL PROTECTED] */ > > + @Override > > + protected void configure() { > > + // TODO: These classes should be moved into the common package. > > + // Once that happens then this common guice module can also move to > > + // java/common. > > + > bind(RemoteContentFetcher.class).to(BasicRemoteContentFetcher.class); > > + bind(GadgetTokenDecoder.class).to(BasicGadgetTokenDecoder.class); > > + } > > +} > > You missed the license header. I will create an issue to prevent this > in the future. > > Cheers, > > Vincent > > [SNIP] >
