Re: Core.io patch for ContentType.FEED support in PHP

[Chris Chabot]

Cool, will do

        -- Chris

On May 7, 2008, at 11:22 PM, Kevin Brown wrote:

Oh, and getSummaries can be !!params.GET_SUMMARIES

On Wed, May 7, 2008 at 2:22 PM, Kevin Brown <[EMAIL PROTECTED]> wrote:

Why don't you go ahead and commit just the javascript parts; I think there

might still be some outstanding issues on the Java code.

On Wed, May 7, 2008 at 2:12 PM, Chris Chabot <[EMAIL PROTECTED]> wrote:

I see this patch is pending for the java implementation too:

--- features/core.io/io.js      (revision 654160)
+++ features/core.io/io.js      (working copy)
@@ -307,7 +307,10 @@
       oauthService : oauthService || "",
       oauthToken : oauthToken || "",
       signOwner : signOwner || "true",
-        signViewer : signViewer || "true"
+        signViewer : signViewer || "true",
+        contentType : params.CONTENT_TYPE || "TEXT",
+        numEntries : params.NUM_ENTRIES || "3",
+        getSummaries : (params.GET_SUMMARIES ? "true" : "false")
     };

     if (!respondWithPreload(paramData, params, callback,
processResponse)) {

The PHP implementation for ContentType.FEED support is done and requires this for its functioning, anyone have any objections to me going ahead and

committing this?

      -- Chris