[
https://issues.apache.org/jira/browse/SHINDIG-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595142#action_12595142
]
Henning Schmiedehausen commented on SHINDIG-247:
------------------------------------------------
do you have a road map of what should go where? There is a lot more stuff that
I have been looking at in the org.apache.shindig.gadgets,
org.apache.shindig.gadgets.http and org.apache.shindig.util package that is in
dire need of refactoring.
> Refactor AbstractContentCache
> -----------------------------
>
> Key: SHINDIG-247
> URL: https://issues.apache.org/jira/browse/SHINDIG-247
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: Henning Schmiedehausen
> Attachments: contentcache.patch
>
>
> The attached patch refactors the code from the AbstractContentCache class a
> bit:
> - add javadocs to AbstractContentCache and ContentCache
> - turn checkContent() into RemoteContent methods:
> - isExpired() whether this RemoteContent object is expired
> - isCacheable() whether this RemoteContent object can be cached
> - updateExpires() modify the headers of the RemoteContent object to
> contain a valid expires header
> - This removes lots of functionality that is not really part of the
> ContentCache from AbstractContentCache and
> turns canCache(RemoteContentRequest rcr) and canCache(RemoteContent rc)
> into very readable code
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
