On Wed, May 7, 2008 at 7:46 PM, <[EMAIL PROTECTED]> wrote:
> Author: chabotc
> Date: Wed May 7 16:46:09 2008
> New Revision: 654329
>
> URL: http://svn.apache.org/viewvc?rev=654329&view=rev
> Log:
> Adding ContentType.FEED support - core.io patch
>
> Modified:
> incubator/shindig/trunk/features/core.io/io.js
>
...
> + case "FEED":
> + if (!data.body) {
> + resp.errors.push("failed to parse JSON");
> + resp.data = null;
> + }
> + else {
> + // Straight into the Feed object - override usual resp structure
> + resp = data.body;
> + }
This section will break consistency in the response object returned by
gadgets.io.makeRequest(), and should be replaced with:
} else {
resp.data = data.body;
}
The applied io.js.patch file is from the first implementation of
SHINDIG-60, which I later updated (latest is
fix-SHINDIG-60-bug_rome2.patch, which patches io.js, ProxyHandler.java
and java/gadgets/pom.xml).
I believe the reason for this handling in the original patch was for
backwards compatibility with existing Google Gadgets, but I
implemented the compatibility layer separately in
fix-SHINDIG-60_legacy.patch -- which modifies just the
_IG_FetchFetchAsJSON() wrapper).
