[
https://issues.apache.org/jira/browse/SHINDIG-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596121#action_12596121
]
Brian Eaton commented on SHINDIG-257:
-------------------------------------
Prior to my patch AbstractContentCache had the same bug you fixed in
BasicContentCacheTest:
private final static DateFormat dateFormat = new SimpleDateFormat("EEE,
d MMM yyyy HH:mm:ss Z");
That's why the tests used to pass for you.
As I was playing around with this I discovered something else interesting:
SimpleDateFormat timezones change permanently when you parse a string. If you
call parseDate() on a string that claims to be pacific daylight time, followed
by formatDate() on a Date object, the formatted date is returned in PDT rather
than GMT.
I hate java.util.SimpleDateFormat. I'm looking at Joda now.
> shindig handling of HTTP dates is not thread safe
> -------------------------------------------------
>
> Key: SHINDIG-257
> URL: https://issues.apache.org/jira/browse/SHINDIG-257
> Project: Shindig
> Issue Type: Bug
> Reporter: Brian Eaton
> Attachments: dateformat.patch,
> org.apache.shindig.gadgets.BasicContentCacheTest.txt,
> TEST-org.apache.shindig.gadgets.BasicContentCacheTest.xml
>
>
> I noticed this during a bit of load testing, spurious exceptions from
> SimpleDateFormat because it isn't thread safe.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
