[ 
https://issues.apache.org/jira/browse/SHINDIG-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596377#action_12596377
 ] 

Cassie Doll commented on SHINDIG-265:
-------------------------------------

Watch your java spacing. All continuing java lines should have 4 spaces of 
indent - your have none. ie:

+  public Activity getEntry(String resourceName, RequestContext request)
+  throws ResponseContextException {

should be

+  public Activity getEntry(String resourceName, RequestContext request)
+      throws ResponseContextException {


besides formatting issues, this code is much much simpler than before. I will 
definitely check it in and then we can refactor the other code to use this new 
style.

> Refactor adapter code to be based on AbstractEntityCollectionAdapter
> --------------------------------------------------------------------
>
>                 Key: SHINDIG-265
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-265
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: David Primmer
>         Attachments: shindig-265_refactor_adapters.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to