[ 
https://issues.apache.org/jira/browse/SHINDIG-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597029#action_12597029
 ] 

Cassie Doll commented on SHINDIG-268:
-------------------------------------

David - I have some further refactoring thoughts for this piece. 

First, we could move the TargetType value from the SocialApiProvider into the 
RequestUrlTemplate enum. After we do that then we can simply have the 
SocialApiProvider get one variable injected - a Map<RequestUrlType, 
CollectionsAdapter>. Then, we can just cycle through all the map entries and 
put them in the routeManager. The provider of the map, call it a RouteFactory 
or something can then be overridden for containers that want custom restful url 
additions. That is all easy enough with guice (and is similar to what the 
GadgetDataHandler does)

Checking in this first refactoring now and then we can continue on this later. 

> Refactor Route managment in the provider
> ----------------------------------------
>
>                 Key: SHINDIG-268
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-268
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: David Primmer
>         Attachments: shindig-268_refactor_route_managment.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to