[ 
https://issues.apache.org/jira/browse/SHINDIG-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cassie Doll updated SHINDIG-267:
--------------------------------

    Attachment: fixLargeTests2.patch

Vasu - I'm not a big fan of turning the XmlStateFileFetcher code into an 
interface. All of the samplecontainer code should be just basic dummy files.. 
and we shouldn't encourage or confuse people about their use by dropping in an 
interface. If we do so, I'm worried some clients might try to actually 
implement the XmlStateFileFetcher class instead of writing to the Service 
interfaces themselves. 

On that note, I took your patch and modified it to instead mock out the service 
interfaces. With this setup you tell each service what people to return (or 
what activities) etc with static vars. This could be cleaner.. but the fact 
that we are running jetty in this way makes things tricky... and I couldn't 
come up with a better idea. 

Let me know what you think.
Thanks!

> Write tests to exercise end-to-end RESTful server code
> ------------------------------------------------------
>
>                 Key: SHINDIG-267
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-267
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>         Attachments: fixLargeTests2.patch, patch.largetest
>
>
> RESTful server code path needs end-to-end tests to exercise as much code as 
> possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to