[
https://issues.apache.org/jira/browse/SHINDIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597400#action_12597400
]
Kevin Brown commented on SHINDIG-269:
-------------------------------------
It doesn't need to do all that. Every file in the features/ directory should be
included in the jar (except for the pom that is being added, of course).
Features aren't necessarily just javascript. The following would be fine:
<resources>
<resource>
<targetPath>/features</targetPath>
<directory>${basedir}</directory>
<excludes>
<exclude>pom.xml</exclude>
<exclude>target/**</exclude>
</excludes>
</resource>
</resources>
This will pick up everything else in the directory. Adding two extra directory
levels to compensate for maven limitations is unnecessary, as only the java
implementation gains anything from this. If <directory> can take the form
${basedir}/** or the like, even the pom.xml and target/** exclusions are
unnecessary as well, but from what I can tell that doesn't appear to be
possible.
The idea behind the patch itself is great -- but that doesn't mean that the
directory structure needs to change.
> package all features in a single jar, load from classpath
> ---------------------------------------------------------
>
> Key: SHINDIG-269
> URL: https://issues.apache.org/jira/browse/SHINDIG-269
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Henning Schmiedehausen
> Attachments: javascript-jar.patch
>
>
> The attached patch creates a Maven project for the features directory. This
> allows automatic packaging up of the features into a single jar, which then
> can be placed on the classpath for the gadget server and the demo container.
> This removes the need for the various javascript related plugins from the
> gadget rendering server and also a number of the cross-project linking and
> copying. The features directory itself is not modified, so the PHP version
> should still run fine.
> In the long run, it might be good to move the features out of the root
> directory and into e.g. src/javascript to allow better control of the jar
> creation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
