Agreed.

Will add to the issue.


On 5/16/08 2:56 AM, "Kevin Brown" <[EMAIL PROTECTED]> wrote:

> You should probably make the default refresh interval configurable for now.
> We should probably get this standardized in 0.9.
> 
> On Fri, May 16, 2008 at 2:52 AM, <[EMAIL PROTECTED]> wrote:
> 
>> Author: lindner
>> Date: Fri May 16 02:52:16 2008
>> New Revision: 656989
>> 
>> URL: http://svn.apache.org/viewvc?rev=656989&view=rev
>> Log:
>> SHINDIG-273 - Add 0.8 support for getProxyUrl()
>> 
>> Modified:
>>    incubator/shindig/trunk/config/container.js
>>    incubator/shindig/trunk/features/core.io/io.js
>> 
>> Modified: incubator/shindig/trunk/config/container.js
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/config/container.js?rev=
>> 656989&r1=656988&r2=656989&view=diff
>> 
>> 
=============================================================================>>
=
>> --- incubator/shindig/trunk/config/container.js (original)
>> +++ incubator/shindig/trunk/config/container.js Fri May 16 02:52:16 2008
>> @@ -58,7 +58,7 @@
>>  "gadgets.features" : {
>>   "core.io" : {
>>     // Note: /proxy is an open proxy. Be careful how you explose this!
>> -    "proxyUrl" : "proxy?url=%url%",
>> +    "proxyUrl" : "proxy?refresh=%refresh%&url=%url%",
>>     "jsonProxyUrl" : "proxy?output=js"
>>   },
>>   "views" : {
>> 
>> Modified: incubator/shindig/trunk/features/core.io/io.js
>> URL:
>> http://svn.apache.org/viewvc/incubator/shindig/trunk/features/core.io/io.js?r
>> ev=656989&r1=656988&r2=656989&view=diff
>> 
>> 
=============================================================================>>
=
>> --- incubator/shindig/trunk/features/core.io/io.js (original)
>> +++ incubator/shindig/trunk/features/core.io/io.js Fri May 16 02:52:16
>> 2008
>> @@ -372,12 +372,21 @@
>>      * Gets the proxy version of the passed-in URL.
>>      *
>>      * @param {String} url The URL to get the proxy URL for
>> +     * @param {Object} opt_params Optional Parameter Object.
>> +     *     The following properties are supported:
>> +     *       .REFRESH_INTERVAL The number of seconds that this
>> +     *           content should be cached.  Defaults to 3600.
>> +     *
>>      * @return {String} The proxied version of the URL
>>      *
>>      * @member gadgets.io
>>      */
>> -    getProxyUrl : function (url) {
>> -      return config.proxyUrl.replace("%url%", encodeURIComponent(url));
>> +    getProxyUrl : function (url, opt_params) {
>> +      var params = opt_params || {};
>> +      var refresh = params['REFRESH_INTERVAL'] || '3600';
>> +
>> +      return config.proxyUrl.replace("%url%", encodeURIComponent(url)).
>> +          replace("%refresh%", encodeURIComponent(refresh));
>>     }
>>   };
>>  }();
>> 
>> 
>> 

Reply via email to