[
https://issues.apache.org/jira/browse/SHINDIG-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597715#action_12597715
]
Santiago Gala commented on SHINDIG-237:
---------------------------------------
I'd say the patch submitted was violating the request of having the COMMITTERS
file, plain text and easy to understand and edit as data "master", and the
generated POM as "slave".
In addition it uses xslt for the extraction, which is one of the most difficult
to handle programming languages that a human mind has invented.
I don't care that much about it, but it is wrong, and it took me a lot of time
to notice: Chris Chabot is not a PPMC member (yet), There are possibly more
bugs on it, but inspecting an XML file is tiring. Also, but this is a minor
one, it generates extra whitespace at the end of the line, after the roles
I'm -1 on this change and would stick to the original proposal by fitz: a text
file as data master and using a script to parse it into a machine usable XML,
just on the grounds of the time that is taking me to find where the bug in the
Chris role and the whitespace handling is.
> Proposed COMMITTERS file for Shindig
> ------------------------------------
>
> Key: SHINDIG-237
> URL: https://issues.apache.org/jira/browse/SHINDIG-237
> Project: Shindig
> Issue Type: Improvement
> Reporter: Brian W. Fitzpatrick
> Assignee: Cassie Doll
> Priority: Trivial
> Attachments: COMMITTERS, SHINDIG-237.patch
>
>
> Patch for creating COMMITTERS file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
