[
https://issues.apache.org/jira/browse/SHINDIG-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597823#action_12597823
]
Kevin Brown commented on SHINDIG-279:
-------------------------------------
This looks like a useful addition (see SHINDIG-173), though there are a couple
of issues:
- Several style issues (mostly whitespace and wrapping)
- Anything configured for common belongs in the common artifact. A new
properties file in common/conf would probably be appropriate.
- Since it appears that ehcache provides a good LRU implementation, it would
make sense to just stick with that as the default and get rid of the one I
threw in there.
- BasicHttpCache can probably become DefaultHttpCache; I believe this
configuration would make this production-worthy for a large number of
deployments. Some of us will still use our own caching solution, but not many.
- The default config should have a higher TTL. Cached files should be
explicitly expired by their http headers, not based on an arbitrary timestamp.
- The Cache itself needs to be injected to facilitate easier testing. Most
tests should use a no op cache.
> Configurable and clusterable cache for Gadgets server
> -----------------------------------------------------
>
> Key: SHINDIG-279
> URL: https://issues.apache.org/jira/browse/SHINDIG-279
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: Ian Boston
> Attachments: SHINDIG-279.patch
>
>
> If the the Gadgets server is going to perform caching, then a configurable
> cache that has all the features that you might expect in production. Attached
> is a patch to put ehcache behind the Cache interface and introduce a
> ShindigCacheManager, that registers with JMX for statistics and management.
> The patch is fully integrated into the gadgets server guice config, with
> tests for each class. It also appears to startup Ok.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
