[
https://issues.apache.org/jira/browse/SHINDIG-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598961#action_12598961
]
Cassie Doll commented on SHINDIG-298:
-------------------------------------
The change was made so that the fetching of xml files is only attempted by one
thread at a time. The code that Kevin wrote to use HttpMethod instead of the
RemoteContentFetcher was not thread safe.
Your change preserves that still - so its all good.
Note: the entire reworking could I'm sure be done better in general. I was just
going for something quick that worked. Anybody, feel free to rewrite it if you
see issues.
Thanks Dan!
> RESTful APIs break with XmlStateFileFetcher change
> --------------------------------------------------
>
> Key: SHINDIG-298
> URL: https://issues.apache.org/jira/browse/SHINDIG-298
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (Java)
> Environment: All
> Reporter: Dan Bentley
> Attachments: shindig-298.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The recent change (r658624) creates XmlStateFileFetcher's without loaded
> data. This makes the RESTful APIs unable to access data.
> I've created a change that exposes a method
> (loadDefaultStateFileIfNoneLoaded) that allows the RESTful services to load
> this data file iff it hasn't been already.
> This somewhat undoes Cassie's change; but I think is a reasonable compromise.
> (That being said, I didn't understand the motivation to her original change,
> and so this may be a Bad Thing. Let me know.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
