[
https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598984#action_12598984
]
Henning Schmiedehausen commented on SHINDIG-297:
------------------------------------------------
I reworked the patch a bit (removed the final qualifiers) and reformatted the
source with eclipse formatter (Sun Style + indent size == 2).
If there more than just the Wiki page about style, how about creating one with
eclipse and putting it on the wiki for download.
To be blunt, while most Apache projects have a given code style and some even
have a "style police", rejecting patches because they are not 100% compliant
with a vague description is a bit unusual to me.
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch, shindig-297-2.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets
> but by other means (using RESTlets, to be exact). Some functionality of
> Shindig is inside the Servlets and this is hard to use if you don't actually
> have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all
> the functionality that is servlet specfic and everything else gets moved into
> JsServer, which contains the Shindig/Javascript specific code. JsServer then
> gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
