[
https://issues.apache.org/jira/browse/SHINDIG-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599308#action_12599308
]
Henning Schmiedehausen commented on SHINDIG-299:
------------------------------------------------
Of course you should not add a dependency to Spring to Shindig. That would be
silly, wouldn't it? Looking at the code in the class above (it is open source)
and then model a loader based on the code that the Spring guys did in a number
of iterations would be my way of action.
Add a line to the NOTICES file saying "this product contains code based on
Spring framework" and you are done. It is Apache licensed, so it is compatible.
The whole idea of open source is to be able to pick existing code and use it in
new and exciting ways. It makes no sense that everyone tries to re-invent the
wheel over and over again just to find out after a number of iterations that
"round" is the best possible shape.
After all, what you are trying to do is .list() on a URL that is based on a
resource and not a file. It is not trivial, especially with the various schemes
of jar-based URLs, but I used that kind of code in a number of projects and it
worked well under various containers (jetty, tomcat, WebLogic).
An alternative, if digging through Spring code is too painful would be
https://facelets.dev.java.net/source/browse/facelets/src/java/com/sun/facelets/util/Classpath.java?rev=1.8&view=markup
but this is CDDL.
> Allow whitespaces in features.txt and commenting out of elements
> ----------------------------------------------------------------
>
> Key: SHINDIG-299
> URL: https://issues.apache.org/jira/browse/SHINDIG-299
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: shindig-299-1.patch
>
>
> ATM, it is not possible to just "comment out" a feature in the features.txt
> file and as soon as you drop a whitespace somewhere, the JsFeatureLoader will
> complain immediately.
> The attached patch allows to comment out features using "#" in the first
> column and it also trims whitespaces. Please apply.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
