On Fri, May 23, 2008 at 8:15 PM, Chris Chabot <[EMAIL PROTECTED]> wrote:
> Very good catch! thanks

Ditto for:

(...)
    git-svn-id: https://svn.apache.org/repos/asf/incubator/shindig/[EMAIL 
PROTECTED]
13f79535-47bb-0310-9956-ffa450edef68

 php/src/{common/SecurityTokenDecoder.php => gadgets/GadgetTokenDecoder.php} |
  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

commit caeb1669a7025a8fc7d0ccbc7673737726b83512
Author: Chris Chabot <[EMAIL PROTECTED]>
Date:   Sat May 10 11:09:05 2008 +0000

    Renamed GadgetToken to SecurityToken, and moved from gadgets to common

    git-svn-id: https://svn.apache.org/repos/asf/incubator/shindig/[EMAIL 
PROTECTED]
13f79535-47bb-0310-9956-ffa450edef68

 php/src/{gadgets/GadgetTokenDecoder.php =>
common/SecurityTokenDecoder.php} |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Same exact thing, I thought you would look into the whole commit for
more suspicious add/renames

I think this is all, HttpUtil -> CertServlet is different enough,
definitely not a "pure" copy.

Regards
Santiago

>
> On May 23, 2008, at 8:10 PM, Santiago Gala wrote:
>
>>
>> I'm not really sure that adding this file makes sense, as it was removed
>> in revision 655046 (and copied to common/SecurityToken.php , which is
>> still there)
>>
>> It that what was intended? it looks suspicious, though I have not looked
>> into the code itself.
>>
>> Regards
>> Santiago
>
>

Reply via email to