[ 
https://issues.apache.org/jira/browse/SHINDIG-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601518#action_12601518
 ] 

Kevin Brown commented on SHINDIG-313:
-------------------------------------

This isn't really the ideal way to handle inline gadgets. Instead, you should 
probably call into GadgetServer directly (or use the metadata service if you're 
not already java based), and then just print the output. This guarantees that 
you're able to control formatting and control flow.

GadgetRenderingTask is already doing way more work than it should be (content 
filters don't belong in there, for instance). This work would be placed 
directly into GadgetRenderingServlet if not for the limitations on servlet 
initialization.

> made GadgetRenderingTask subclassable
> -------------------------------------
>
>                 Key: SHINDIG-313
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-313
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Adam Wight
>            Priority: Minor
>         Attachments: rendering.patch
>
>
> Making private members of GadgetRenderingTask "protected" allows us to reuse 
> this code to create new rendering servlets.  In particular, we have written 
> an "html-inline" servlet to substitute for the deprecated html-inline Content 
> type.  Inline rendering for trusted gadgets enables full interaction with the 
> DOM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to