[
https://issues.apache.org/jira/browse/SHINDIG-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601942#action_12601942
]
Chris Chabot commented on SHINDIG-329:
--------------------------------------
Hmm i guess for developers (like yourself) this could be a useful setting.
However in production i don't see how anyone could use this, especially since
it makes it rather hard to honor the refresh interval params etc.
At the very least please always do a if (!empty()) before setting the key,
right now you have:
+ curl_setopt($request->handle, CURLOPT_PROXY,
Config::get('proxy'));
but it's not very useful to always set this even if the proxy param is empty,
better safe then sorry in such cases!
Anyone else have some opinions about if this should be in the svn repo or not?
> Add a proxy in the config file
> ------------------------------
>
> Key: SHINDIG-329
> URL: https://issues.apache.org/jira/browse/SHINDIG-329
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Gonzalo Aune
> Attachments: proxy.patch
>
>
> We need a proxy configuration to use with Shindig
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
