[ 
https://issues.apache.org/jira/browse/SHINDIG-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603072#action_12603072
 ] 

Chris Chabot commented on SHINDIG-295:
--------------------------------------

I've committed the patch but there are a few comments i have. 

First of all it didn't work since the require 'PHPUnit/*.php' are not on my 
local include path, so i did the same trick as we did with the zend framework 
and used some command line magic to mass rewrite all the statements using:

Also when pulling in external libs it's important to mention where you got it 
from and what license it's published under, and preferable put this in a README 
file, so i went ahead and created a README file in the PHPUnit directory 
documenting the command line magic to mass rewrite the require statements, and 
list the license and project home page url's.

Also the .htaccess file didn't work for me (broke everything) so i went back to 
the -d and -f rewrite rules, this allows tests to function, but i hope it 
doesn't break things for other people, mod_rewrite tends to be a bit 
temperamental at times :)


So with that taken care of we get to the important point ... it doesn't work 
yet!

/test/common/ and /test/socialdata/ give me the following output:

Notice: Undefined variable: dir in 
/Users/chabotc/shindig/php/test/socialdata/index.php on line 8
Test Cases
PHPUnit 3.2.9 by Sebastian Bergmann.
Time: 0 seconds
OK (0 tests)

/test/gadgets/ seems to give a svn properties dump of some kind (listed below)

So please try to address these issues so we get a working test suite. I 
committed this since other people were waiting for PHPUnit to land so they 
could add their tests too, but this has been done under the assumption you'll 
follow up with a patch to actually make this work correctly :)

Output i got with /test/gadgets/:
K 25 svn:wc:ra_dav:version-url V 67 
/repos/asf/!svn/ver/663970/incubator/shindig/trunk/php/test/gadgets END 
GadgetContextTest.php K 25 svn:wc:ra_dav:version-url V 89 
/repos/asf/!svn/ver/663970/incubator/shindig/trunk/php/test/gadgets/GadgetContextTest.php
 END index.php K 25 svn:wc:ra_dav:version-url V 77 
/repos/asf/!svn/ver/663970/incubator/shindig/trunk/php/test/gadgets/index.php 
END GadgetIdTest.php K 25 svn:wc:ra_dav:version-url V 84 
/repos/asf/!svn/ver/663970/incubator/shindig/trunk/php/test/gadgets/GadgetIdTest.php
 END 8 dir 663970 
https://svn.apache.org/repos/asf/incubator/shindig/trunk/php/test/gadgets 
https://svn.apache.org/repos/asf 2008-06-06T14:55:55.362859Z 663970 chabotc 
svn:special svn:externals svn:needs-lock  GadgetContextTest.php file 
2008-06-06T14:48:48.000000Z 8a98ddb9d9b2fdb49423617feef988e7 
2008-06-06T14:55:55.362859Z 663970 chabotc  index.php file 
2008-06-06T14:48:48.000000Z f70ca05cd76bc5d7dd4efb3c9fa60366 
2008-06-06T14:55:55.362859Z 663970 chabotc  GadgetIdTest.php file 
2008-06-06T14:48:48.000000Z 04bcdddf63bc220930c9c1f87f6e9f12 
2008-06-06T14:55:55.362859Z 663970 chabotc  8 



> PHPUnit
> -------
>
>                 Key: SHINDIG-295
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-295
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Common Components (PHP)
>            Reporter: bruno rovagnati
>         Attachments: PHPUnit.patch
>
>
> PHPUnit Framework + first implementations of TestCases

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to