On Wed, Jun 11, 2008 at 11:00 PM, Brian Eaton <[EMAIL PROTECTED]> wrote:

> I just discovered some test cases that appear to indicate that
> ModulePrefs.toString() needs to serialize the module prefs as a
> well-formed XML document.  Where is this functionality being used?  Is
> it important?


Only for debugging. I added the toStringIsSane tests to ensure that anyone
modifying the specs include them in toString operations.


> Most of the code invoked by ModulePrefs.toString fails to escape XML
> metacharacters, so this is prone to breakage.


Yes --  it's not intended as a serialization mechanism, though if we do
decide to make GadgetSpec serializable, we certainly could support this.

Reply via email to