[ 
https://issues.apache.org/jira/browse/SHINDIG-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Chabot resolved SHINDIG-359.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

Patch looks great!

One thing though, the code formatting was a bit non standard, but that was 
nothing that the code formatter couldn't fix. There's a few more of such 
inconsistencies.. wish you had Zend Studio for Eclipse so you could use the 
proper formatting file :)

I did a simple test or two (wrote a quick gadget that used a normal pre-load) 
and that checked out fine ... i'll have to do a bit more extensive testing to 
test the oauth signed version later today or tomorrow, but it all looks to be 
in good order. 

Nice to have preloading and authenticated preloading in php shindig! So great 
patch & nice work! 


> add the "authz" attribute to the "Preload" element
> --------------------------------------------------
>
>                 Key: SHINDIG-359
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-359
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Gadget Rendering Server (PHP)
>            Reporter: Chris Chabot
>            Assignee: Chris Chabot
>         Attachments: preloadfeature-SHINDIG-359.patch
>
>
> Support this element, and its attribute (and hook up functionality). The 
> authz attribute can be set to "signed" on preload elements to allow 
> developers to say that the preloaded content should be fetched with a signed 
> request.
> See: 
> http://www.google.com/url?q=http://groups.google.com/group/opensocial-and-gadgets-spec/browse_frm/thread/8fddcff4534e6e&sa=D&usg=ALhdy2-CUN_nz3mgITW3j9fPnzxOAHG_Rg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to