[ 
https://issues.apache.org/jira/browse/SHINDIG-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Chabot resolved SHINDIG-390.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

Hmm you raise a very good point there, however i think your patch is incorrect 
... it shouldn't always fetch all app data for all your friends + your self, 
instead if should look at the GroupId type and go from there.

Ie if it's just @viewer/@self, it should fetch the app data for just the 
viewer, if its @owner/@friends, it should fetch the app data of all the owner's 
friends.. Currently that GroupId parsing was completely lacking (my bad), so 
i've added that and that should fix your problems, in a spec compliant way :)

Let me know how it works out for you!
 

> Sample Container - Friends App data is not coming from the Server
> -----------------------------------------------------------------
>
>                 Key: SHINDIG-390
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-390
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (PHP)
>         Environment: Windows, Apache
>            Reporter: impetus technologies
>            Assignee: Chris Chabot
>         Attachments: BasicAppDataService.php.patch
>
>
> In /php/src/socialrest/samplecontainer/BasicAppDataService.php it seems like 
> there is some code is missing related to friend Ids fetching which is very 
> well done  in BasicPeopleService.php. That's why sample container is not able 
> to fetch the app data for friends. We have made some changes our side and 
> it's working fine.
> Patch file is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to