[ 
https://issues.apache.org/jira/browse/SHINDIG-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606380#action_12606380
 ] 

Chris Chabot commented on SHINDIG-395:
--------------------------------------

patch looks good, ill see about committing later today once im back to my main 
computer.

ps, it's always a good idea to do a:
if (is_array($scan_paths)) {
   $locations = array_merge($scan_paths, $locations);
}

else it's a fatal error and bug reports in the future :)

That being said most 'multiple config keys' use a , separated string and not an 
array type so it's probably better to do a:

if (!empty($scan_paths) {
   $locations = array_merge(explode(',', $scan_paths), $locations);
}


> Local configuration file and extension class path
> -------------------------------------------------
>
>                 Key: SHINDIG-395
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-395
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Common Components (PHP)
>         Environment: n/a
>            Reporter: Karsten Beyer
>            Priority: Minor
>         Attachments: fix-issue-SHINDIG-395.patch
>
>
> There should be a possibility to store local configuration values outside of 
> svn control. The attached patch includes a local.config.php if it exists in 
> which configuration values can be overwritten.
> Additionally in order to keep the container specific handlers and other 
> classes cleanly separated from the shindig project, it should be possible to 
> add paths in which classes are searched for. This is implemented by adding 
> the "extension_class_paths" parameter which should be an array of paths which 
> is then used in the __autoload function to search for extension classes.
> Patch will be attached immediately...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to