I'm not really sure that it makes much of a difference -- I was concerned about having something that was both inherited from and used for composition. The patch looks good to me, though most of the motivation for the ServletTestFixture was using the better testing facilities in junit4 (which is not based on inheritance).
I'd get rid of the EasyMockTestCase if the mock controller is baked into the fixture. On Sat, Aug 30, 2008 at 12:23 AM, Brian Eaton <[EMAIL PROTECTED]> wrote: > Kevin - Is the patch attached to > https://issues.apache.org/jira/browse/SHINDIG-551 anywhere close to > what you had in mind? > > On Fri, Aug 22, 2008 at 11:18 AM, Brian Eaton <[EMAIL PROTECTED]> wrote: > > On Fri, Aug 22, 2008 at 11:15 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > >>> Ah, so test cases would either inherit from EasyMockTestCase or > >>> include a fixture, but not both. If they included the fixture, they'd > >>> inherit from TestCase (or not inherit at all, just use the @Test > >>> annotation.) > >>> > >>> Want me to implement that? > >> > >> If we do that across the board, we need to remove mock generation from > other > >> places. > > > > I'd just do it for places that currently inherit from > > GadgetTestFixture or ServletTestFixture. Test cases that don't use > > those classes already will remain in blissful ignorance of the messy > > dependencies of their less fortunate brethern. > > >
