Ok, I've read the thread, and as always issues are more complex that at first glance, thats what makes life interesting.

So, if the test works on an absolute url it will test the the ability of jetty to deliver content, whereas if its relative it will test the ability of the gadget rewriter to proxy the relative reference.

Which it should be probably depends on what the test is trying to cover ?
If it covers proxies it should probably remain as relative.

Ian

On 16 Sep 2008, at 14:06, Kevin Brown wrote:

On Tue, Sep 16, 2008 at 1:53 AM, Ian Boston <[EMAIL PROTECTED]> wrote:

I have a feeling that this is due to a problem in the gadget caching code
that performs the concatenation.

Have a look at https://issues.apache.org/jira/browse/SHINDIG-500

At the time, testframework.js was not being served up by the gadget
rewriting.
It is part of the gadget and hence was/should be relative to the gadget.xml
(not absolute)

You *can* also make it work by changing the path to / testframework.js which happens to be the real location of the file, only because errorTest.xml is
also at /errorTest.xml.


I don't know the Gadget spec that well, but common sense says that
references inside a gadget should work when relative to the location of the XML specifying the gadget... otherwise it become painful to relocate the
gadget to somewhere else, even on the same server.

Is that right or are all references absolute ?


Yes, except for message bundles. Part of my proposal to add proxied content is to support relative urls everywhere. See this discussion for background:

http://groups.google.com/group/opensocial-and-gadgets-spec/ browse_thread/thread/50722f096c7a5746/9b2e40d61d837208

Adding support for relative urls to shindig doesn't address the problem in
general. The compliance gadget, for instance, will still have to use
absolute paths, because those paths will not be interpreted as relative on
other containers (say, myspace).




Perhaps a real test of the gadget would be to host them in a location other
than / on the jetty server.

Ian


On 15 Sep 2008, at 22:53, [EMAIL PROTECTED] wrote:

 Author: lindner
Date: Mon Sep 15 14:53:51 2008
New Revision: 695650

URL: http://svn.apache.org/viewvc?rev=695650&view=rev
Log:
Some versions of jetty are not serving up the testframework.js files.
 odd.

Modified:

incubator/shindig/trunk/java/server/src/test/resources/endtoend/ errorTest.xml

incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPeopleTest.xml

incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPersonTest.xml

Modified:
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ errorTest.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/
server/src/test/resources/endtoend/errorTest.xml? rev=695650&r1=695649&r2=695650&view=diff

==================================================================== ==========
---
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ errorTest.xml
(original)
+++
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ errorTest.xml
Mon Sep 15 14:53:51 2008
@@ -24,7 +24,7 @@
  </ModulePrefs>
  <Content type="html">
    <![CDATA[
- <script type="text/javascript" src="testframework.js"></ script> + <script type="text/javascript" src="/testframework.js"></ script>
      <script type="text/javascript">

        var tests = {

Modified:
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPeopleTest.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/
server/src/test/resources/endtoend/fetchPeopleTest.xml? rev=695650&r1=695649&r2=695650&view=diff

==================================================================== ==========
---
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPeopleTest.xml
(original)
+++
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPeopleTest.xml
Mon Sep 15 14:53:51 2008
@@ -24,7 +24,7 @@
  </ModulePrefs>
  <Content type="html">
    <![CDATA[
- <script type="text/javascript" src="testframework.js"></ script> + <script type="text/javascript" src="/testframework.js"></ script>
      <script type="text/javascript">

        var tests = {

Modified:
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPersonTest.xml
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/
server/src/test/resources/endtoend/fetchPersonTest.xml? rev=695650&r1=695649&r2=695650&view=diff

==================================================================== ==========
---
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPersonTest.xml
(original)
+++
incubator/shindig/trunk/java/server/src/test/resources/endtoend/ fetchPersonTest.xml
Mon Sep 15 14:53:51 2008
@@ -24,7 +24,7 @@
  </ModulePrefs>
  <Content type="html">
    <![CDATA[
- <script type="text/javascript" src="testframework.js"></ script> + <script type="text/javascript" src="/testframework.js"></ script>
      <script type="text/javascript">
        var tests = {
          /** Test fetching a specific ID */





Reply via email to