Done. I attached a new patch file to the issue (as Compile-Time-Msg-Substitution.2.patch) - didn't bother updating the code review though.
Thanks for responding so quickly. On Mon, Oct 6, 2008 at 3:29 PM, John Hjelmstad <[EMAIL PROTECTED]> wrote: > Lev: > Just for clarity, put some parens around os.VAR_msg + '.' in compiler.js > and I'm happy to commit it. > > John > > On Mon, Oct 6, 2008 at 12:23 PM, Lev Epshteyn <[EMAIL PROTECTED]> wrote: > >> Changed, and uploaded new patch - unfortunately I needed to create a new >> code review for it: >> >> http://codereview.appspot.com/7257 >> >> >> On Mon, Oct 6, 2008 at 2:55 PM, <[EMAIL PROTECTED]> wrote: >> >> > Few short comments. >> > >> > >> > http://codereview.appspot.com/7256/diff/1/3 >> > File features/opensocial-templates/compiler.js (right): >> > >> > http://codereview.appspot.com/7256/diff/1/3#newcode857 >> > Line 857: // (and gadget messages are obtaibable), inline it here. >> > s/obtaibable/obtainable >> > >> > http://codereview.appspot.com/7256/diff/1/3#newcode861 >> > Line 861: var key = token.split(".")[1]; >> > Handling of syntax errors eg. no "." present? >> > >> > >> > http://codereview.appspot.com/7256 >> > >> > >
